[device_info_plus] Add regression integration tests#1038
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds two integration tests to verify that tizenInfo is consistent across repeated calls and that TizenDeviceInfo.fromMap correctly round-trips through data. Feedback on the integration tests suggests improving the consistency test; because tizenInfo caches results internally, comparing calls on the same instance only compares the object with itself. The reviewer recommends asserting identity using same() and instantiating a second plugin instance to properly verify consistent data across separate native channel calls.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
device_info_plus_tizen is a standalone Tizen plugin with its own public API (DeviceInfoPluginTizen / TizenDeviceInfo) and does not pin a specific upstream device_info_plus version. For reference, when the current plugin (1.4.0) was implemented the contemporaneous upstream was device_info_plus v12.4.0 (v13.0.0 landed a couple of days later) — its data getter / deprecated toMap API pattern is what the plugin mirrors. The existing tests already assert every TizenDeviceInfo field; this adds regression tests for the parts of the public API not yet covered: - tizenInfo is consistent across repeated calls (cached/idempotent) - TizenDeviceInfo.fromMap round-trips through the data map Validated on a Tizen TV (10.0) and Raspberry Pi 4: all tests pass (4 passed, 0 skipped, 0 failed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bfb3879 to
0759459
Compare
Remove the full data map comparison between two plugin instances. availableRamSize and freeDiskSize are volatile values that change between native calls, causing the equals() assertion to fail in CI. Checking modelName alone is sufficient to verify that a new instance returns consistent static device data. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 participants
device_info_plus_tizen is a standalone Tizen plugin with its own public API (DeviceInfoPluginTizen / TizenDeviceInfo) and does not pin a specific upstream device_info_plus version. For reference, when the current plugin (1.4.0) was implemented the contemporaneous upstream was device_info_plus v12.4.0 (v13.0.0 landed a couple of days later) — its data getter / deprecated toMap API pattern is what the plugin mirrors.
The existing tests already assert every TizenDeviceInfo field; this adds regression tests for the parts of the public API not yet covered:
Validated on a Tizen TV (10.0) and Raspberry Pi 4: all tests pass (4 passed, 0 skipped, 0 failed).
#1039